Skip to content

GROOVY-11636: Create a SGM#next method which also takes an integer in…#2204

Merged
paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy11636
Apr 28, 2025
Merged

GROOVY-11636: Create a SGM#next method which also takes an integer in…#2204
paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy11636

Conversation

@paulk-asert
Copy link
Copy Markdown
Contributor

@paulk-asert paulk-asert commented Apr 24, 2025

…crement value

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 24, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.9434%. Comparing base (8f6b192) to head (6d45abc).
⚠️ Report is 533 commits behind head on master.

Files with missing lines Patch % Lines
...g/codehaus/groovy/runtime/StringGroovyMethods.java 50.0000% 9 Missing and 8 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2204        +/-   ##
==================================================
- Coverage     68.9482%   68.9434%   -0.0048%     
- Complexity      29569      29576         +7     
==================================================
  Files            1423       1423                
  Lines          113916     113950        +34     
  Branches        19761      19773        +12     
==================================================
+ Hits            78543      78561        +18     
- Misses          28775      28784         +9     
- Partials         6598       6605         +7
Files with missing lines Coverage Δ
...g/codehaus/groovy/runtime/StringGroovyMethods.java 83.1593% <50.0000%> (-1.5402%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eric-milles
Copy link
Copy Markdown
Member

eric-milles commented Apr 25, 2025

@blackdrag raised concern that charAt should probably be code point at. And is there a next code point method? Any concern about invalid/unmapped code points?

@paulk-asert
Copy link
Copy Markdown
Contributor Author

paulk-asert commented Apr 25, 2025

I commented in the issue. I was following the code from next()/previous().

@paulk-asert paulk-asert merged commit c343276 into apache:master Apr 28, 2025
21 checks passed
@paulk-asert paulk-asert deleted the groovy11636 branch April 28, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulk-asert @codecov-commenter @eric-milles